Log of /branches/noatun

Step 4: Delete the branch, as we are now working in trunk again. Hoorah!

This concludes the "4 step process" of bringing noatun out of a branch

Now how about giving me karma to delete the noatun directory from branches?

[13:52:13] <njaard> /home/kde-common/svn/hooks/pre-commit.pl: user `charles' does not have permission to commit to this path:
[13:52:13] <njaard>   branches
[13:52:15] <njaard> funny
[13:52:30] <lypanov> ...
[13:52:36] * lypanov remembers why he stopped working on kde :)

Step 1: port branch to kde4. If you can get it compiled and installed, it may even work! In terms of plugins: only the bare essentails are ported for now. And it looks very bizarre!

To compile this: You need to copy admin from KDE3 in, and then apply adm1n.diff (note that it's not "adm[eye]n" but "adm[one]n.diff" - because some comedian decided that you're not allowed to commit any file that has "admin" in the name.

If someone wants to fix cmake so that it can compile noatun, that'd be fine too.

This is just between you and me. Now let us agree to never talk about it again.

how long as it been since I made a commit?

- ItemType can now be not a pointer (untested)
- setGamma(0.0000001) (GRR!)

compile

uh.. install the skins?

don't sigsegv when going backwards from the first item on the list

Prevent assertion failure in ItemData constructor from happening when listview
is empty.

- add a loadPlugin to the dcop iface
- make the system tray plugin load :)

that's it, I can't take it any longer.  I'm comitting it. 2200 lines of diff.

I'm terrified, I didn't want to do this; but here it is, the new playlist API.

Changes:
- In order to make it clear that the playlist should not store its own
data in PlaylistItemData, that interface is now gone, it's merely just a
template class now. There is no interface.
- all functions affecting the data are in the PlaylistInterface class
- PlaylistInterface is a template, it inherents from a semi-secret Generic
class.
- Yes, it works :)

Simpleplaylist doesn't compile, and Stefan seems to hate it now, so I didn't
port it.  I will if he asks me to.

THIS IS AN RFC.  I want *feedback* on this API, I want *questions* so I can
document and improve it.  Please!

There are still gaps.  There is yet to do an iterator class.

SplitPlayList is a dead end as well, I'll have to just rewrite it correctly.
It's been around for 5 years.  It was ported over to noatun2 without any design
fixes, and now I've done that again for make-it-snow.

- readd that code that I removed
- finally make that stupid toolbar have items like "Add"

- prevent an automatic copy constructors
- copy lots of SPL code around so it doesn't crash enough
- make the reference counting truly under-the-hood, so you can't do stupid
 things like the SPL did.

- FIX: also load other plugins at startup, not only engine, playlist and mainwindow

Do not assert when there is no plugin to play things with

put class PlaylistItem into its own source file...

This is just a little step in fixing the Playlist API

goodbye

I've really wanted this plugin for a long time.  Now I can actually code
Noatun again now that I can use it!

Try all this:
1) use the selected plugin from noatunrc
2) use the default one
3) use any plugin that implements the interface

that's the correct way according to KPluginInfo's source code

Be C++ (gcc4)

be c++, the kind that gcc4 likes

- ugh, remember SimplePlaylistItems also if they were fetched from DB, not only newly created ones, this might have lead to duplicate items for the same id
- add debug menuitem to show all known playlist items (uses KdDebug() as output)

don't add a reference to something just so that it becomes derefenced and
deleted behind our backs.

fix a couple of errors

grr, moc is too stupid for #if 0

- make use of NMainWindow
- adapt to changed PlaylistItemData constructor
- remove unneeded window show/hide code, it's in libnoatun now

- remove unneeded window hide/show code, it's in libnoatun now
- adapt to new NMainWindow constructor

Adapt to changed NMainWindow constructor

- move list of playlist-notifiers into Playlist class and port to QValueList
- hide ugly window hide/show logic from playlist-plugins and move into Playlist and PlaylistInterface, no need to duplicate the code in every plugin
- add and update apidocs-comments, I could really need some help here, I suck at writing docs :(
  TODO: Find a way to make doxygen created docs for Noatun::NMainWindow, it somehow barfs on that file
- FIX: Hide dock-widgets for skinned windows before showing them for the first time
- hide PlaylistItemData refcounting functions from the public, only PlaylistItem and PlaylistItemData itself are allowed to play with the counter
- add more d-pointers
- get rid of unused file volumecontrol.h, that api turned out to be unneeded
- exclude unused sources from apidocs
- install all used public headers, forgot some in there
- get rid of some Global::self() use

unused_code--;

Ok, this seems to work on both unserbreak and autobreak now

Import of SimplePlaylist.
This is meant to replace the buggy SplitPlaylist that has annoyed many users due to frequent crashes and general weirdness (it never heard about "document centric working").
NOTE: SimplePlaylist depends on QtSql and its SQLITE-driver, this will probably need some configure check.

- revert Makefile.am changes, I'll fix this another time when testing it on KDE 3.4 and automake
- Update TODO

- adapt to PlaylistSaver API-changes (metalist() -> load())
- Finally fix the looong standing bug that makes Noatun randomly crash, SplitPlaylist silently delete PlaylistItemData object although they were still referenced by PlaylistItem objects (affected functions are List::clear() and SafeListViewItem::remove())

use new PlaylistItem::[FsetProperties() call

- add PlaylistItem::setProperties(), it can help playlists doing bulk insertions and stuff when setting many properties at once
- redo PlaylistSaver API, load(someUrl, Default) now guesses the playlist-format, metalist() is now private
- do not download the same file multiple times on metalist(), only download it once when guessing the format
- add a typedef Noatun::PropertyMap to make property-functions a bit more readable

remove own apidocs hack in favor of using the kde-wide apidox rule

compile
install the right files
(hey! I'm using a noatun without arts)

nice job metz

compile

- Add aKode plugin. NOTE: it cannot play non-local files yet (neither can gstreamer-engine)

- update totally outdated TODO file with random thoughts
- remove other outdated files

Restore last known volume when loading a plugin containing an EngineInterface. Not sure if using KConfig directly is the best idea

- Don't crash when switching between (broken) playlists, shutdown Player properly and set a NULL-Playlistitem

- make Engine an Interface as well (i.e. playback functionality can now be in a plugin)
- move NoatunApp (app.cpp and app.h) out of library/ and into app/, this also includes getting rid of "napp"
- Create Config class for central settings, available through global->config()
- move configuration tabs from library/ into app/, no need to have that code in a library every plugin links against
- version information is now in noatun/version.h because its former locatin (app.h) is gone
- make default playback backend a plugin, arts-engine is born :)
- add (experimental) gstreamer-engine plugin
- Don't link anything against arts-stuff except for arts-engine itself

NOTES:
- equalizer, effects, visualization, video and probably more stuff is gone for now, it'll come back as EngineInterface evolves
- engine selection is non-existant, edit noatunrc for now if you want to try out gstreamer

sort out branches