Log of /branches/kolourpaint

more sugar

+TODO

Polish

Fix up mainWindow/ and top-level.

more sugar

Finish commands/

Actually rename the other way so that the names are distinct in the Kate file list.

more info on brush sizes

Standardize naming.

Clean up layers/ and tools/ docs.

Document pixmapfx/ and imagelib/ fully.

placeholders

Document document/ package.

More sugar.  My email is pretty much emptied.

Clean up

SVN_SILENT more sugar

Add code auditing scripts for before releases.

Add script that finds enabled debug, which should be disabled before each KolourPaint release.

Fork gen_mimetype_line.sh for KolourPaint/KDE4.

Add all the easy-to-write docs.

Suck content out of DOC-TODO.txt; more/less sugar.

Suck content out of DOC-TOD.txt's.

Rename to mark as a file we have to extrct the content out of.

tidbit from mobile, spacing

Move dpi.txt

Append TODOs from over the years.

Rename to DOC-TODO.txt and add unsorted "TODO" sectoin.

Merge in local changes.

Rename dirs.

SVN_SILENT +TODO

Revert botched revertlast and fix original botched commit

revertlast botched commit

Add more dirs.

Move textual class diagram.

Add 32-bit screen discussion.

Add 2003-12-07 doc.

Move paint-engine.txt to new folder code-walk-thru/imagelib/

Polish and old doc I never uploaded.

Dump .ODT out into text files, with some editorial changes too.  Text files are more accessible.

Add config dialog from 2004-02-17 14:15:04 +1100

Move kde4port/ into scripts/kde4port/, since it only contains scripts now.

Refer to these scripts in TODO.

Consume contents of kde4port/TODO into TODO (the rest has already been consumed by the src code).

More sugar.  Also remove things mentioned elsewhere and things that are obvious.

Point to http://bugs.kde.org.

Pass 2: reorder, add contents

Pass 1:

- Remove obsolete stuff (there will be no more KolourPaint 1.2 backports)
- Remove implemented stuff
- Clarify some TODOs
- Remove items that are merely pointers to bugs already documented in BUGS

-empty dir

Finally, after years (!), all of trunk/KDE/kdegraphics/kolourpaint/ has been ported to Qt4 or marked with "COMPAT".  Hopefully, there are no more silent semantic changes to Qt4 that I missed.

Finished reviewing patches.

I'm still a bit worried about isHidden() vs isVisible() vs isShown() [deprecated]
and hide() vs setVisible() vs show().

SVN_SILENT reviewed

Reviewed.  Much of it was fixed in:

    Revision 550227
    Modified Sun Jun 11 08:08:58 2006 UTC (16 months ago) by dang 

Move script out of KolourPaint-specific folder.

This is the script I used for processing list.txt (which I just deleted).

Reviewed all 2005 patches.

SVN_SILENT reviewed all 2006 patches, except the other ones in suspicious/

SVN_SILENT reviewed all of 2007

SVN_SILENT reviewed

SVN_SILENT reviewed

SVN_SILENT I mean the icons display so what more could I ask? :)

SVN_SILENT remove those already covered by suspicious/

SVN_SILNET --list.txt

SVN_SILENT --checked

Expand explanations of strings like "TODO".

Remove some items implemented for KDE4 (except that we offer a warning at <16bpp, not <24bpp).

Start moving docs into new devel_doc/ dir.

kpPainter managed to get things done without this class, so it no longer has anything to do with the kde4port/.  Rather than deleting it (since it's hard to get things back in SVN), I'll just move it.

SVN_SILENT --patches

All the commits I didn't make :)

SVN_SILENT -TODO: already mentioned in both trunk/ and branches/KDE/3.5/

Move non-kolourpaint-specific script out of branches/kolourpaint and into branches/work/~dang.

According to:

~~~~
Date: 2007-06-22 3:27 am
   
SVN commit 678559 by binner:

fix invalid .desktop files
~~~~

the "MimeType=" line must have a trailing semicolon.

Mark branch as dead.  I put an enormous amount of effort into this branch
but in the end, a lack of time bit me.  Sadly, this work will go to waste
-- there has not been a release since 1.2.2_kde3 (late 2004).

more sugar

Document what "REFACTOR" is, -TODO

-TODO:

* The first and last bits of removed text were recently copied over to Bug #96086 and Bug #89594 respectively.

* The rest was already covered by bugs.kde.org bug reports.

Rearrange for KolourPaint 4.  Add some [comments].

+bug #

more/less sugar

Explain "sync" some more

Document some more KolourPaint code keywords like "STRING".

+TODO

explain CONFIG

explain LOTOD

+TODO

Patch fixed in -r651332.

Finished camelcasing files in /branches/work/~dang/kdegraphics/kolourpaint/

Finished using the script on /branches/work/~dang/kdegraphics/kolourpaint/

Add script which converts all "#include <kptheclass.h>" in STDIN to "#include <kpTheClass.h>".

Delete scripts I've finished using

Add script

Same as change-subclass-filenames-to-camel-case.sh but works on base classes only

Add a neat script which changes all .cpp/.h pairs, containing subclasses, to CamelCase.

+TODO

Document all (not totally sure) of the character styles.

* Write a lot about selections (we still need to discuss more on undo/redo)

* Cover the Color Picker being undoable and the problem with linear command histories

* +GPLv3 TODO

* Add everything I want to say about DPI

* +TODO in "Paint Engine" section

+TODO

* Point out bits the website that aren't uploaded

* Add plugin loophole for incorporating GPL code

* Cover abusing server memory and shaders

* Add MMX/SSE mention

* Start "Commands" section with explanations from "Internal" and "External" points of view

* Add "1 - mouseButton ()" idiom to the "Tools" section

   * Fix crash triggered by rapidly deselecting a selection after 
     drag-scaling the selection (Bug 117866) 
     [before inserting "kpToolSelectionResizeScaleCommand" into the command 
      history, finalize the smooth scale so that the "m_smoothScaleTimer" 
      is disabled] 
 
   * Up ver to 1.2.6_kde3-pre

[BACKPORT of fix to branches/KDE/3.3/]
 
Needs forward porting to trunk/KDE/ (KDE 4).
 

+TODO

-TODO implemented by r613781

+TODO

+/- TODO

update TODO

* Rearrange

* +TODOs about my current checkout

* Add Coverity to "Technical Resources" section

* Explain why all kpMainWindow slots end the current shape, under new "Code Patterns" section

* Start explaining kpTool's shapes vs ordinary draw pattern

* Start explaining kpTool's user notification (statusbar messages)

merging TODOs

append kolourpaint part of branches/work/~dang/kde-devel-2006.txt

+examples for 1.

+TODO before I forget

developer guide started; +TODO

add note about TODO's

* Change our mind: we will put implementation detail in here except for really low-level stuff

* Define "PICTURE"

* Mention trunk/ compilation dependencies and speed

* Add "Code Reliability" and "Code Readability" sections

* Write bulk of "Tools" section

* Add stub "Temp Pixmaps" section

+new term: HITODO; better explanation of HACK and move it around

* Mention implementation details elsewhere

* Suggest inserting images, rather than copying

* Document Page Styles

* Add "Language", "Licensing", "Paint Engine" sections

* Expand "Selections" section

* Minor editorial changes

Move all text (but not class diagram) from design.txt into .odt

more Current Work

add more "Current Work"

+TODO

Start adding content.

fix extra . in generated OOo doc

more doc

* Add start of developer guide

* Add Makefile documentation

Add automagic build system for coming OpenOffice.org document [from private document repository r403]

clarify #6

SVN_SILENT there is no measurable startup time improvement in removing the credits (including KApplication construction) :)  Maybe the About dialog loads faster, who cares.

+TODO

Add KDE4 porting TODO

looked at these patches and they seem OK

mark -r567206 (en_US -> en_AU comments) as reviewed

merge forgotten changes

+TODO

reviewed -r560635

Avoid confusion with people porting this stuff - move kde4port/ to an unreleased branch.

update TODO

text toolbar patch for Qt3
[part of kolourpaint-static-checkerboard.diff]

SVN_SILENT partial merge from July 2005

Patch for 1.2.2_kde3 to allow the Tools KToolBar's context menu to change
icon size, instead of doing nothing.

Too dirty to apply.  Maybe later if another _kde3 release is to be done.

[from June 2005]

+TODO

Version 1.2.5_kde3 (Unreleased Frozen 2006-03-15)

   * Printing improvements (Bug #108976)
     - Respect image DPI
     - Fit image to page if image is too big
     - Centre image on page

   * Fix kpMainWindow::saveDefaultDocSize() debug

[BACKPORT of branches/KDE/3.5/kdegraphics/kolourpaint:r517830 to sync with KDE 3.5.2]

Adriaan de Groot makes a good point on his blog

longer changelog for just commited kolourpaint.in

obsolete for post-1.2.2_kde3 

2005 update for 1.2.4_kde3 that was supposed to happen but didn't (these scripts are not fully up-to-date for a 1.2.5_kde3 nor a 1.4_relight_kde3):

* build: --enable-final
* 1.2.2_kde3.control -> 1.2_kde3.control to minimise hassle with every new ver + CVS -> SVN

* kolourpaint.in:
 - Put instructions in wrapper script for actually running KolourPaint in case
   user accidently opened script in text editor.

 - Support running kolourpaint from a symlink to the wrapper, stored in a
   different dir to the wrapper.

 - Only delete docs symlink when number of running instances of KolourPaint
   bin reaches 0.

 - kolourpaintui.rc hack

 - Debian docs

 - ABI selection

* collectsrc: SVN, no unwanted kolourpaint.desktop check, compensate for TODO in control branch, doc update

Better documentation in control branch.

for some reason, this file was "svn added" locally - must have meant something during my script writing

document release procedures (1.2_kde3/kdegraphics/kolourpaint/dist will be updated shortly - this and previous commits were slightly ahead of themselves)

more scripts

reminder to update

update

Begin merge of uncommitted 2005 patches: "stamp" - a file for making arbitrary comments in SVN history

really update mimetypes to KDE 3.5; now really release virtual release

Release virtual release 1.2.4_kde3 to stay in sync with virtual release 1.2.4 (branches/KDE/3.3/), which itself was to stay in sync with 1.4.3_light (branches/KDE/3.4/) and 1.4_relight (branches/KDE/3.5/).

SVN_SILENT fix instruction; KDE SVN seems to be more dynamic than the code that's in it...
[also in branches/KDE/3.[543]/]

* update "typeForMimeMap" up to KDE 3.5
* fix "typeForMimeMap" instructions

add NEWS for last 2 commits

   * Prevent accidental drags in the Colour Palette from pasting text
     containing the colour code

   * Cells in the bottom row and cells in the rightmost column of the Colour
     Palette are now the same size as the other cells

[also in branches/KDE/3.[345]/]

   * Text drops to the empty part of the scrollview will not be placed
     outside the document
     [also in branches/KDE/3.[345]/]

up-to-date docs

comments

   * Correct and update image format associations to all formats supported
     by KDE 3.5pre (kdelibs/kimgio/:r437289)
   
   * Update kolourpaint.desktop translations from branches/KDE/3.3

better mark &Settings possible translation problem as COMPAT

1. Fix duplicate (standardised) "Settings / Full Screen Mode" option in KDE >= 3.4         

2. warning about XML changes affecting future KolourPaint wrapper script for "version" parsing
   [change #2 also in branches/KDE/{3.5,3.4,3.3}]

Add "hacked-index.cache" which, as usual, is index.cache compiled by a recent KDE 3 and hacked to have no "help:/" references.

Make a copy of the KDE doc commons since KDE 3.0 won't have it (except unneeded Makefile.am README.Doxygen appheader.html).

Remove to allow future svn copy.

Make backported bugfixes and InputMethod support compile on KDE/Qt 3.0.

Turns out kolourpaint-1.2.2_kde3-thumbnail_blink_text_cursor.diff which was applied long ago does not actually compile on Qt 3.0 (use of QPtrList::const_iterator).

fix warnings

[also in branches/KDE/{3.5,3.4,3.3}]

Document 1.2.3_kde3 -> 1.2.4_kde3 (premature version increase).

NEWS: Mention that this is a backport of branches/KDE/3.3/ (was in global TODO I deleted);
mention InputMethod as sole exception

Avoid mentioning ver num to reduce maintenance hassle.

Explain why you should not and how to compile from source properly.

When I first used Linux, the most useless documentation I read was
the generic GNU INSTALL (which is retained at the bottom of this file):

./configure && make && make install

did not work for me because the generic instructions fail to explain
that ./configure fails if you are missing libraries and that make
fails if the build system is buggy.

lastWallpaperMode increased from 8 to 9 in KDE 3.4

sync with BUGS in trunk/, branches/KDE/3.4/, branches/KDE/3.3/:

* "this version" to reduce maintenance hassle
* remove bug 24, add 25 & 26

Differences to other branches:

* up backport suggested KDE ver from 3.3 to 3.4
* keep backport info since this is the backport branch

SYNC typeForMimeMap up to r437289 (today, post KDE 3.4); point to SVN, not CVS.

dfaure said that bug is a feature

for keeping image mimetypes in sync

more sugar

incomplete documentation

Resources for all backport, non-KDE releases (kind of like "kde-common/release/")

Changes merged from branches/KDE/3.3/kdegraphics/kolourpaint/TODO to self merged into branches/kolourpaint/control/TODO.

Merge changes between branches/KDE/3.3/kdegraphics/kolourpaint/TODO/ [just deleted] to branches/kolourpaint/1.2_kde3/TODO [will also be deleted]

Things get reassigned from version to version so frequently that it's pointless to maintain a separate TODO file for each version and this way, we get a nice global view.

From trunk/kdegraphics/kolourpaint/TODO which was equal to branches/KDE/3.4/kdegraphics/kolourpaint/TODO

From trunk/.  Still need to adapt from CVS to SVN.

add

For global project overview documents and standalone release elements that shouldn't be in trunk/ as they would otherwise be tagged by KDE.

Painter::drawText() increases line heights to >QFontMetrics::height() if you type Chin
ese characters (!) so the cursor gets out of sync.  To fix: hand craft kpselection.cpp:drawTextLines() which draws one line at a time.

BACKPORT of trunk/, branches/KDE/3.4/, branches/KDE/3.3/

Click on right half of text character now positions text cursor on next text character
(instead of the one under the mouse) to be consistent with all other text editors (really noticeable with big fonts).

BACKPORT of trunk/, branches/KDE/3.4/, branches/KDE/3.3/

Return and numpad 5 key now draw as would be expected since Enter already does.

BACKPORT of trunk/, branches/KDE/3.4/, branches/KDE/3.3/

Tool Actions placed outside the Tool Box are no longer fixed in size and resize with their toolbars - pass icon name string, not QIconSet, to action ctor.

BACKPORT of trunk/, branches/KDE/3.4/, branches/KDE/3.3/

Ensure Color Similarity maximum is 30, not 29 due to gcc4 double -> int cast behaviour

BACKPORT of trunk/, branches/KDE/3.4/, branches/KDE/3.3/

Permit right clicks in the empty part of the Tool Box (for the RMB Menu).

BACKPORT of trunk/, branches/KDE/3.4/, branches/KDE/3.3/

Don't permit selection of tool options with RMB - pass it to the toolbar for the toolba
r context menu.

BACKPORT of trunk/, branches/KDE/3.4/, branches/KDE/3.3/

fix warning

point to websvn, not webcvs

credit kzk for InputMethod (without listing role as that would add a string)

FEATURE backport r381439:384220 by kzk [in trunk/, branches/KDE/3.4/]

"
Add (basic) InputMethod support to KolourPaint!

Ensure using InputMethod by calling setInputMethodEnabled (true)

When the text which is composed by InputMethod, update correctly the microFocusHint, which is to be used by CandidateWindow.

fix my last committing miss.
"


--- kpview.cpp  (revision 381439)
+++ kpview.cpp  (revision 384220)

Backport r385288 [already in trunk/, branches/KDE/3.4/ and more recently, branches/KDE/3.3/]

Text boxes with opaque foreground & transparent background now antialias
text with document below (finally! - this was one of the last few basic
features that KolourPaint was missing).  Render on demand instead of
blitting a pixmap with a transparent background (which can't possibly
antialias with doc).

Remove unused "evenIfText" arg from kpSelection pixmap accessors.

Backport r385292 [already in trunk/, branches/kde/3.4/ and more recently, branches/kde/3.3/]

Change "Set As Image" a.k.a "Crop" behaviour for the 2nd time.

Old: Selection pulled off, moved to (0,0), document set to background
     colour outside of selection and where selection opaque
Problems: Like with "Edit / Copy to File...", it was found that pulling
          off selection was unexpected (if sel set to trans and esp.
          with Colour Similarity on).  Furthermore, setting doc pixels
          to background colour is artificial without much justification
          - it attempts to simulate sel pull-off but why not just paste
          down the sel in the first place ("Set as Image", after all)
          to allow pull-off.  And it doesn't work well with antialising
          opaque foreground text with transparent background.
New: If text box, same behaviour as old (move to (0,0)), except doc
     background always becomes completely transparent (avoids false
     antialising with transparent text box background and for opaque
     text box background, makes extend of text box clearer if moving
     text box).  So as with old, not really "Set as Image" but we want
     to keep text box editable - you can just deselect it afterwards
     anyway.

     If ordinary selection, firstly, no pull-off.  Second, it _really_
     pastes down / sets the selection as the doc (bits of doc outside sel
     _region_ are set to background colour).  So the selection is gone
     (even if it was floating before).  For convenience, it adds a create
     sel border cmd immediately afterwards.  You can then pull off the
     sel if you must.

Hopefully new behaviour is more intuitive.  Thanks to Michael Lake for the
feedback regarding the unexpected pull-off.

Add kpToolClearCommand constructor overload to specify a particular back colour.

sort out branches