Log of /branches/KDE/3.5/kdebase/kicker/kicker/ui/service_mnu.cpp

Fix focus with RMB/Put Into Run Dialog. I didn't even know K-Menu could do this.

let translators decide how this gets laid out should they wish to, as
per the request of some of them.
also, use a '-' by default. nicer than ()s and ' ' doesn't work for
enough people. so be it.

reduce visual clutter due to descriptions by not using parens and
avoiding duplicating the name in the description or vice versa
CCMAIL:celeste@kde.org

Multi-head fixes:
* Put into run dialog (open the run dialog on the current screen)
* Add item/menu to panel (add it to panel on the current screen)

allow d'n'd in kmenu when panel is Locked (but not kiosk'd)
BUG:124245

allow rmb on locked panels (but still not kiosk'd panels, of course)

use KickerLib::menuIconSet

still hunting miscompilations ;/

when we are collapsing a single menu item down, don't use the menu's
name as then the user can't tell what the heck is going to launch.
and --debug while we're at it ;)

don't show the context menu if we are locked or if there is nothing to
show due to kiosk restrictions
BUG:113647

ignore "unknown" icons in all code paths

we really don't want to show the "unknown" icon

don't show "paper" icon for bigger menu icon sizes if icon is missing
create a transparent icon so that entry doesn't get lower than others

show buttons in pressed state even when triggered by keyboard
for Danimo 

call close() after hitting the event loop to prevent getting stuck in a
nested event loop
BUG:111220

don't show separators at the end of menus unless there are items that
follow. based on a patch by Jonathan Marten. thanks Jonathan!
BUG:110702

branching of 3.5 and arts 1.5 

don't crash on exit when menuexts are in the kmenu and kicker is closing
down. this is accomplished by keeping these in a separate list in the
kmenu and only deleting them from the kmenu during normal operation

consolidate the loading of the icon set based on the menu entry height
preference
put "add non kde app" in the add application to panel menu for
completeness. i'm not a fan of the name, but that's what it's called
elsewhere. maybe "add an application that isn't in this menu" if only it
weren't so gosh darned long. ;)

The Quicklauncher can now display the most popular applications,
similar to the Most Recently Used/Most Often Used section of the kmenu.
The kmenu emits a DCOP signal when an application is started.
The kmenu and the quick launcher both wait for this signal to
update their usage stats. If a launched application is present
in the quick launcher, it will blink a few times now to tell the
user that he could have started the program with fewer mouse clicks.

The dynamic mode of the quick launcher works not exactly like 
the MRU/MOU-list of the kmenu. Instead it tries to take both
short term and long term usage into account. The weighting between
short term and long term usage can be selected in the new 
configuration dialog, which also replaces several existing menu
options. 
The exact meaning of this slider is a bit hard to communicate, but
on the other hand it allows for a compromise between the two extreme
strategies MRU and MOU. The best default value has yet to be found,
but I guess that something around 75% should be fine in the long run - 
at first it's always a bit jumpy though, because there are no long
term usage statistics - unless we not only provide a list of default
applications, but also some guessed statistics for them.

Applications appearing dynamically in the quick launcher can be pinned
down, so that they stay there no matter what. Applications inserted
manually will also be in that mode initially. 
The dynamic mode is disabled by default.

The quick launcher has been converted to use the new configuration 
framework and the kmenu/service menu has been slightly refactored.
The latter can keep the bug count constant at best, but it helps 
keeping Aaron happy ;)

BUG: 46639

delete submenus when a servicemenu is deleted
KickerLib::reduceMenu

Fix various Kiosk things. Approved by aaron.

* Don't allow right click anywear on kicker
* Don't allow drag & drop if Kicker is immutable
* Don't show the help menu if it's not allowed

move kicker-the-app into kicker/kicker/
rename share/ to libkicker
fix the Makefile.am's to reflect this.
knowing how Makefiles hate me, i'm sure i
missed something somewhere. huzzah.

more janitorial work. remove more QPtrLists
and fix const_iterator usage (we could
probably use const_iterators in more places =)

moved kdeaccessibility kdeaddons kdeadmin kdeartwork kdebindings kdeedu kdegames kdegraphics kdemultimedia kdenetwork kdesdk kdetoys kdeutils kdevelop kdewebdev kdepim kdebase kdelibs kde-i18n arts into /trunk/KDE/

Added "Description only" menu item format

Break the kicker config tabs into standalone KCModules. Show them in kcontrol as a single module. Show them in kicker as separate modules.

KConfigXTize the "Menus" and "Appearance" modules (partly).

Simplify life.

Spec said "When inline item + header + alias_inline we doesn't display header"

Add all xdg menu standard support.
Ok'ed by Waldo.
Perhaps a backport for kde 3.4.1 ?

no icons is
[menus]
MenuEntryHeight=-1
BUG:36375

close context menu, if the parent menu is hidden or on an additional click in the menu

not perfect, because context menu stays when you right click on an item in a submenu

BUG: 99098

remove a dead connection

use the KConfigXT settings

use KickerSettings throughout kicker instead of accessing Kicker::the()
put global.h into a namespace (KickerLib)
all in libkickermain, allowing things to link to that directly instead of
ALL of kicker *cough*taskbarextension*cough*

close menus after dragging items out of them
patch graciously contributed by Stefan Nikolaus

BUG:81438
BUG:88940
CCMAIL: stefan.nikolaus@stuco.uni-oldenburg.de

handle multiple kmenu buttons properly
BUG:49601

correct default settings

CVS_SILENT remove useless include

move the two functions in popopposition into global to try and keep these
stray methods all in one place

BUG:92864
make a servicemenubutton when dragging a group from the kmenu, uses a
programs:/ link

merge stop_the_insanity for QA and wider development cooperation
STI has become less buggy than HEAD, though there are still some TODOs

Finer/more correct Kiosk restrictions, added "Put Into Run Dialog"

+"Add Menu to Desktop" (programs:/ link)

+"Add Item to Desktop"

BUG:77274
one of those "so obvious i couldn't see it" bugs

Added context menu entries to add menu/item to the main panel (#4229)

Fix potential mem leak

Add menu context menus with "Edit Group" respectively "Edit Item" entry
which launch the KDE menu editor and preselect the selected group/item.
CCMAIL: 4229@bugs.kde.org, bastian@kde.org

Bug 15611: [Patch] wish: kicker menu items size (wishlist)
Patch by SUSE, adds "[menus] MenuEntryHeight=48" option to kickerrc

Fix K-menu with ShowMenuTitles=false (BR77274)

Run kbuildsycoca, while it's running open K-Menu, wait for kbuildsycoca
to finish, run some application from the K-Menu -> boom. QPopupMenu emits
aboutToHide() before actually handling the click, so the popup gets redone
before the click is handled.

fix for crash http://bugs.kde.org/show_bug.cgi?id=71899

Kick #4229 back to wishlist

avoid temporaries. runs here forever ...

Correct alphabetical sort for every supported menu item format
Binary incompatible change, with advice and blessing from Waldo

Default to "Descript (Name)" menu item format as proposed on kde-core-devel

make menu title configurable with

[menus]
ShowMenuTitles=true

for small screens and small minds

* Alt-F1 pops up KDE-menu above KDE-button
* Support for kde-menu --highlight

Don't allow selecting titles in popups.

Support separators in KDE menu.

Fix the updating of menus after they close in case a ksycoca update happens
while they are visible.

compiler warning fixes

* fix bug in section titles after update
* Indicate correctly "Most Used Applications" / "Recently Used Applications"

According to the Linux Usability Test Report of Relevantive the
"recently used" apps section in the KDE menu is confusing to users
because they don't understand what it is and why it changes.
This is a first attempt to address this usability issue by adding
section titles to the KDE menu.

gcc 3.3.1 fix - shouldn't cast KSharedPtr<foo>->KSharedPtr<bar>, but rather
cast foo* to bar* and let it become a ksharedptr again.

Fix compilation.

added DCOP call to clear QuickStart a.k.a. RecentApps menu via privacy module

judging by the comment and the surrounding code, 22 was a typo and should
be 20: // make sure they are not larger than 20x20

s^QUriDrag^KURLDrag^

No need to use QRegExp anymore.

reverted my last commit -> separators and titles will come when we have a
standard on this

Alex

Scale icons to proper size in KDE menu. (Also for submenus)

make it possible to have separators and titles in the KMenu

Alex

fix Bug#49113

Disable tear off handles:
tear off handles don't work together with dynamically updated
menus. We can't update the menu while torn off, and we don't know
when it is torn off.

CVS_SILENT Capitalization

Clean up some of this initialize/reinitialize mess. kdelibs update required.

split initialize() in two parts: initialize() and doInitialize()
to make subclassing PanelServiceMenu easier (see e.g.
kicker/menuext/prefmenu)

optional preferences menu, patch courtesy of
Oliver Bausinger <bausi@everest.mathematik.uni-tuebingen.de>

GUI: changes to reflect new kicker kcm and to help usability:

 o explicitly state what the user is about to configure in the applet,
   button and panel context menus
 o don't show the panel menu in the applet menu
 o clarified the add/remove menus (e.g. button -> application button)
 o add Description (Name) mode to kmenu to compliment Name and
   Name (Description) modes

Don't initialize the whole K-Menu on Kicker startup, as that can take
really some time with large K-Menu.
The real fix should be calling reinitialize() here, and making
KPanelMenu::reinitialize() call initialize() only when the popup menu
is visible, but that doesn't work with torn-offs, so it needs a fix in Qt
... grmbl :( @!%#!

Always use the correct config group.

When configuration changes, reinitialize to hide/show all detailed menu entries.

-added username next to Logout to see as which user we're logged in on that display/machine
-fixed tearoff handles to work only when that is enabled in kdeglobals
-configuration option needed for that value anyway :(

CVS_SILENT Capitalisation fixes.

Prevent Qt warnings about non-existing menu-entries after updating menu.
+    s_RecentApps.m_nNumMenuItems = 0;

use GenericName instead of Comment

Start services with the "no wait" option so that kicker doesn't freeze.

smoothscale icons larger than 20x20 instead of 16x16 (requested by tackat)

Support for "Detailed menu entries" option. Entries are restricted to a sane maximum length of 60 characters.

Fix #36511 #36403 #34376

Fix endless loop and X hang.
Please make sure to call the implementation of the base class when you reimplement closeEvent.

revert waldos patch

Name --> Name (Comment)

CVSSILENT: fixincludes

Disable a bunch of (configure) options when you don't have write access to
kickerrc. (Kiosk support)

Fix typo

Menu capitalization fix

- prefix the values for the global enums Position, Direction and Size
  with '::' to solve the clash with Qt::Dock on qt3
- style and include fixlets
- qt_set_sane_enterleave does not exist in qt3 anymore but instead
  this behaviour is default

  David tested this patch on qt2 so it shouldn't really break anything :)

New menu extension: dynamically loaded menu entry to be plugged
either in the K-menu or in the panel. See kdeui/kpanelmenu.h for
more informations.

Use KServiceGroup::childCount() to avoid having empty submenus.

Fixed that famous k-menu-overlap bug.
Thanks to Mattias Dahlberg for reproducing.
Thanks to Corel for introducing.

Nice captions for torn off menus.

more tear offs

Fixed the crash on databaseChanged(). There were two mistakes
* missing  subMenus.clear(); in service_mnu (initialize), so the submenus
were in the list twice - and deleted twice !
* the bookmarks popupmenu was kept in a pointer but also in the autodelete
list. Bad :). We have to recreate it each time initialize() is called.

BTW, the init sequence sucks a bit. The K menu is built twice, because
reinitialize is called by PanelButton::configure... Not sure how to make
that better, I'll leave that to the kicker developers :-)

corel code cleanup

fix

fixes and cleanups

fixed possible security holes

added new GUI feature: "most Recently/Frequently used" section at the top of kmenu

WABA: Fix memory leak when clearing menu.
The problem is that if you clear a QPopupMenu you have to take care of the
submenus yourself (e.g. either reuse or delete them). On exit the submenus
got deleted because they had their parent set, so strictly speaking they
were "accumulated" and not "leaked" but the effect was the same.

Clearing isn't working properly for PanelServiceMenu. It leaks memory
somewhere, and I'm not sure where. For now, I'm disabling clearing. This
removes the memory leak, but means that ksycoca updating won't have any
effect. Anyone have a nice memory leak tool they can investigate with ?

In base_mnu, the timer is connected to slotClose() in the ctor. This
doesn't work when you override slotClose() in a derived class. Fixed
by putting the connect() elsewhere. I think the real fix might be to
create the QTimer on the heap.

Rik

kdDebug() -> kdDebug(1210)

KIconloader returns large icons when it can't find a small versiomn even if the KICon::Small override flag is set. This makes the K-Menu look ugly on some systems (COL for example ;-). ServiceMenu will now check the size of the icons returned by KIconLoader and smoothSacle 'em if required.

Combined "Add->Application and Add->Submenu" into "Add->Button".
This seems to be more intuitive.

- Added a ServiceMenuButton + Container
- "Add->Submenu" will add a ServiceMenuButton now.

- cleaned up panel menu
- added "add->submenu" option

This should fix a number of ugly crashes on kicker startup.

    KServiceGroup::Ptr root = KServiceGroup::group(relPath_);
+   if (!root || !root->isValid()) return;
    KServiceGroup::List list = root->entries(true);

Who broke this ? I only just fixed displaying of active/inactive icons in
correct style according to user's settings. Now it's broken for no reason
other than laziness.

Use QUriDrag::setFilenames for local files, and NEVER prepend
"file:" before a path !

Better don't show the unkown icon when there's no icon available.
Approved by Matthias Elter and Tackat.

replaced printf statements with kdDebug methods.
replaced qDebug statements with kdDebug methods.

Fix icon highlighting. Patch sent to core-devel but no takers.

Matthias Elter's drag'n'drop patches from kde-core-devel

We had way to many source files in the toplevel. Restructured the sources as discussed with Rik some time ago.